Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matter end-device implemented in Python #8589

Closed
wants to merge 4 commits into from
Closed

matter end-device implemented in Python #8589

wants to merge 4 commits into from

Conversation

markus-becker-tridonic-com
Copy link
Contributor

@markus-becker-tridonic-com markus-becker-tridonic-com commented Jul 23, 2021 •
edited
Loading

Problem

Currently there is a Python matter controller in the source tree. There is no Python matter end-device.

Change overview

This PR facilitates to create a Python based matter end-device.

  • Adds python/chip/server/ServerInit.cpp and Python wrapper
  • Adds Python lighting device sample with README in examples/lighting-app/python
    • This sample requires a DALI-USB-interface
  • Checked onnetwork / ip commissioning and BT/WiFi commissioning
  • In the initiial version of this PR a modified controller-clusters.zap was used. Now the correct lighting-app.zap is used.
  • build-chip-wheel.py was auto-formatted

Testing

  • Manual test of the new Python matter end-device against chip-device-ctrl running on the same host computer as described in the README of the sample added with this PR.

markus-becker-tridonic-com and others added 4 commits July 23, 2021 09:48
@markus-becker-tridonic-com
Initial matter Python end-device
2f5ac94 
This PR facilitates to create a Python based matter end-device.

* Adds sample with README in examples/lighting-app/python
  * This sample requires a DALI-USB-interface
* Checked onnetwork / ip commissioning only
* Adds server clusters for Python matter end-device to controller-clusters.zap
  * Possibly this should be split into another zap file, but hard to get the
    build system set up without duplicating code. Help/Suggestions welcome.
* build-chip-wheel.py was auto-formatted
* Typo fixed in operational-credentials-server.cpp

TODO:

[ ] check whether WiFi/BLE commissioning would work
@markus-becker-tridonic-com
modified zap generated files
cc08d63
@restyled-commits
Restyled by clang-format
6041f79
@restyled-commits
Restyled by gn
22e752f
@restyled-io restyled-io bot mentioned this pull request Jul 23, 2021
Closed
@github-actions
Copy link

Size increase report for "esp32-example-build" from f382df3

File Section File VM
chip-ipv6only-app.elf .flash.text -172 -172
chip-shell.elf .flash.text -32 -32
chip-lock-app.elf .flash.text 64 64
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,172
.flash.text,-172,-172

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,32
.flash.text,-32,-32

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,64,64
[Unmapped],0,-64

@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from f382df3

File Section File VM
chip-qpg6100-lighting-example.out .text 8 8
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.text,8,8
[Unmapped],0,-8

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

@stale
Copy link

stale bot commented Jul 30, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 30, 2021
@stale stale bot removed the stale Stale issue or PR label Jul 30, 2021
@yunhanw-google yunhanw-google mentioned this pull request Jul 30, 2021
Closed
@stale
Copy link

stale bot commented Aug 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 6, 2021
@stale
Copy link

stale bot commented Aug 13, 2021

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Aug 13, 2021
@yunhanw-google yunhanw-google reopened this Sep 8, 2021
@stale stale bot removed the stale Stale issue or PR label Sep 8, 2021
@stale
Copy link

stale bot commented Sep 15, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 15, 2021
@stale stale bot removed the stale Stale issue or PR label Sep 16, 2021
@stale
Copy link

stale bot commented Sep 23, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 23, 2021
@stale
Copy link

stale bot commented Oct 1, 2021

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Oct 1, 2021
@markus-becker-tridonic-com
Copy link
Contributor Author

This PR has been reworked and rebased in https://github.com/markus-becker-tridonic-com/connectedhomeip/tree/matter-python-end-device-master. Would be great if it could be reopened.

FYI: @yunhanw-google

@markus-becker-tridonic-com markus-becker-tridonic-com changed the title Initial matter Python end-device matter end-device implemented in Python Oct 27, 2021
@markus-becker-tridonic-com markus-becker-tridonic-com mentioned this pull request Oct 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelderton jelderton jelderton approved these changes

@selissia selissia selissia approved these changes

@woody-apple woody-apple woody-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@hawk248 hawk248 Awaiting requested review from hawk248

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
app controller darwin examples review - approved stale Stale issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markus-becker-tridonic-com @yunhanw-google @woody-apple @selissia @jelderton @restyled-commits